Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows deps #1986

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Update windows deps #1986

merged 1 commit into from
Mar 30, 2023

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Mar 6, 2023 •
edited
Loading

Tested and validated locally on my Windows system.

@Starbuck5 Starbuck5 requested a review from a team as a code owner March 6, 2023 00:54
MyreMylar
MyreMylar approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works on my windows machine 👍

@ankith26
Copy link
Member

ankith26 commented Mar 7, 2023

I'd like to hold this PR till mac/manylinux is updated as well. Which I'd like to tackle soon-ish

@Starbuck5
Copy link
Member Author

I'd like to hold this PR till mac/manylinux is updated as well. Which I'd like to tackle soon-ish

I was going to request that PR from you, but you're already thinking of it :)

@Starbuck5 Starbuck5 force-pushed the update-windows-deps branch from a59713a to cbeaac2 Compare March 19, 2023 08:51
@Starbuck5 Starbuck5 force-pushed the update-windows-deps branch from cbeaac2 to e9ef6f3 Compare March 19, 2023 08:52
@ankith26 ankith26 mentioned this pull request Mar 26, 2023
Merged
@oddbookworm
Copy link
Member

Seems fine on Windows 11 from my testing

>>> import pygame
pygame-ce 2.2.0.dev1 (SDL 2.26.4, Python 3.11.1)
>>> pygame.init()
(5, 0)
>>> pygame.print_debug_info()
Platform:               Windows-10-10.0.22621-SP0
System:                 Windows
System Version:         10.0.22621
Processor:              AMD64 Family 23 Model 8 Stepping 2, AuthenticAMD
Architecture:           Bits: 64bit     Linkage: WindowsPE
Driver:                 windows

Python:                 CPython
pygame version:         2.2.0.dev1
python version:         3.11.1

SDL versions:           Linked: 2.26.4  Compiled: 2.26.4
SDL Mixer versions:     Linked: 2.6.3   Compiled: 2.6.3
SDL Font versions:      Linked: 2.20.2  Compiled: 2.20.2
SDL Image versions:     Linked: 2.0.5   Compiled: 2.0.5
Freetype versions:      Linked: 2.11.1  Compiled: 2.11.1

@Starbuck5 Starbuck5 merged commit c7b9ee4 into pygame-community:main Mar 30, 2023
@Starbuck5 Starbuck5 deleted the update-windows-deps branch March 30, 2023 04:03
@Starbuck5 Starbuck5 added this to the 2.3 milestone Mar 30, 2023
@Starbuck5 Starbuck5 modified the milestones: 2.3, 2.2.1 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddbookworm oddbookworm oddbookworm approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
buildconfig Windows
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Starbuck5 @ankith26 @oddbookworm @MyreMylar